Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JIP event removal on dedicated client #1253

Merged
merged 1 commit into from
Nov 16, 2019
Merged

Fix JIP event removal on dedicated client #1253

merged 1 commit into from
Nov 16, 2019

Conversation

mharis001
Copy link
Contributor

When merged this pull request will:

  • Fix CBA_fnc_removeGlobalEventJIP not correctly removing events when called in "wait for object deletion" mode on non-server machine when the object is deleted after the client disconnects
  • "Deleted" EH won't exist after the client disconnects and as such the event is never removed, unless added on server

@commy2 commy2 changed the title Fix JIP event removal on non-server Fix JIP event removal on dedicated client Nov 16, 2019
@commy2
Copy link
Contributor

commy2 commented Nov 16, 2019

3.13?
Did you actually run into an issue with this?

@commy2 commy2 added the Bug Fix label Nov 16, 2019
@mharis001
Copy link
Contributor Author

mharis001 commented Nov 16, 2019 •
edited
Loading

Yes, nothing major. Just code that would silently fail when given objNull, this will ensure it doesn't run at all. Could add if (isNull _object) exitWith {}; but I think this is the better solution.

@commy2 commy2 added this to the 3.13 milestone Nov 16, 2019
@commy2 commy2 merged commit 34cbd23 into CBATeam:master Nov 16, 2019
@mharis001 mharis001 deleted the fix-jip-event-remove branch November 17, 2019 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 commy2 approved these changes

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
3.13
Development

Successfully merging this pull request may close these issues.
2 participants
@mharis001 @commy2